Clear AsyncFd readiness in read_event - #7
Open
RoastVeg wants to merge 1 commit into
Open
Conversation
|
Just a ping to see if we can have this merged? I've verified that it works in my code, but it can also be tested with the CLI—without this commit |
|
Polite ping! This is a very important fix. Without it, |
AlonaSolntseva-Nanit
added a commit
to nanit/gpiod-rs
that referenced
this pull request
Apr 7, 2026
Use guard.try_io() instead of discarding the AsyncFd ready guard. Without this, the second call to read_event() gets a spurious readiness notification and fails with EAGAIN (os error 11). Port of katyo#7 Co-Authored-By: Louis Hampton <louis@ecog.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@seimonw correctly identified in #6 that tokio-gpiod fails in repeated calls to
read_eventwith EWOULDBLOCK/EAGAIN, but mistakenly assumes it's due to NONBLOCK having been set. This is actually due to the fact that the readiness flag inAsyncFdis not cleared after the first call toreadable.The easiest way to solve the problem is by following the example given in the
AsyncFddocs