feat(react): desktop shell: header, sidebar nav, week progress - #399
Merged
Conversation
Sticky header (serif title, today date, search pill, New reminder button), sticky sidebar with All/Today/Upcoming/Done nav counts and active state, and THIS WEEK progress block per the redesign handoff. Search input and view selection only hold state for now: list filtering ships with the search/filters issue. New reminder keeps navigating to /reminder/create until the modal issue lands. Cypress: list button renamed Create Reminder to New reminder across specs; new desktop shell spec; API-failure spec asserts the shell instead of the now-empty list column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppHeadercomponent: sticky header with serif page title, today's date, search pill (magnifier icon, no focus ring), and theNew reminderprimary button (replaces the oldCreate Reminderbutton).Sidebarcomponent: sticky aside with All/Today/Upcoming/Done nav (counts, active state with accent dot andaria-current) and the THIS WEEK progress block (uppercase label, 40px serif percentage, 5px bar, overdue-aware caption).reminderGroupsutil growsviewCountsandweekProgress(percent done of reminders due within 7 days, overdue included, matching the prototype).maincolumn. Three nav color tokens added toglobals.css; unusedpage.module.cssdeleted.Closes #328
Test plan
npm test: 100/100 passing, including new AppHeader, Sidebar, util, and list shell tests.next lintandnext buildclean.api-dotnet.cy.jsneeds the live .NET API and is unaffected by this change.