feat(react): search and view filters - #400
Merged
Merged
Conversation
Wire the header search pill and sidebar views to the list. A new filterReminders util combines the view (All/Today/Upcoming/Done via the existing bucket logic) with a trimmed, case-insensitive query over title and description; groups derive from the filtered set while sidebar counts and week progress stay global, matching the design prototype. Empty states are left for #332.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterReminders(items, view, query)inreminderGroups.ts: view filter via existingbucketOf(All passes everything), query trimmed and case-insensitive over title and description.Closes #329
Test plan
npm test)next lintcleanreminders-list.cy.jsagainst localnext dev: 7/7 pass, including new spec "should filter the list by view and search"