feat(mvc): redesigned list views with grouping and progress - #401
Merged
Conversation
Apply the reminders redesign to the MVC app list page, server-rendered: header with title, date, search and New reminder; sidebar with All/Today/ Upcoming/Done counts and week progress; grouped cards with date pills, done toggle, edit and delete. Create, edit and delete open as modals over the list, replacing the legacy Bootstrap pages (Bootstrap and jQuery removed). Also fixes found on the way: the MVC client serialized PascalCase JSON that the cpp API rejected on update, and the edit form posted no id, which the dotnet API rejected with 409. Selenium suite now runs on Linux/WSL: drivers via Selenium Manager (bundled binaries removed), headless, selectors for the new markup, wait for modal close after submit. Firefox row is opt-in (MVC_TEST_FIREFOX=1) since snap Firefox hangs under geckodriver on WSL. CLAUDE.md: hand over a test environment plus test cases before opening a PR, skippable on request. Closes #334 Closes #380 Refs #335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?view=Today&q=text)./Reminders/Create,/Reminders/Edit/{id},/Reminders/Delete/{id}render the list with the modal open; POST validation errors re-open it with inline field errors). Legacy Bootstrap views, Bootstrap CSS and jQuery removed.RemindersIndexViewModel+ReminderGroupsmirror the ReactreminderGroupsutil (bucketing, labels, counts, week progress).LimitDate.Datenow map to the form field..exeremoved), headless, null-safe cleanup, base URL defaulthttp://localhost:5050(MVC_BASE_URLoverride), selectors for the new markup,WaitForAbsenceafter modal submits (fixed a read-before-navigation race). Firefox row opt-in viaMVC_TEST_FIREFOX=1(snap Firefox hangs under geckodriver on WSL).Remaining from #335: mobile breakpoint under 760px.
Closes #334
Closes #380
Refs #335
Test plan
dotnet buildforReminders.MvcandReminders.Mvc.Testcleandocker compose --profile api --profile mvc: grouping, counts, progress, view/search filters, toggle, create/edit/delete modals, inline validation errors verified via curl and headless Chrome screenshotsdotnet test src/test/app/dotnet/Reminders.Mvc.Testagainst localhost:5050: Chrome row green on 19 of 20 repeated runs (one timeout right after a container rebuild, not reproduced afterwards), Firefox row skipped by default