feat(ci): gate review on workflow runs and apply caveman and ponytail - #405
Conversation
Check runs register only when a job starts, so a workflow whose jobs were still queued was invisible to the first poll. Workflow runs exist from trigger time; poll those for the PR head and require every run except the review workflow itself to be complete and green. Closes #404
95985de to
9b9474b
Compare
|
Reviewed the diff (workflow gate fix + ADR-0008 wording update). No prior review comments on this PR to reconcile against. Findings [minor] Checks performed
Ready for human review. |
Review finding: a small margin for API propagation across sibling runs of the same push.
Vendor the caveman skill (MIT, JuliusBrussee/caveman) and add a ponytail skill under .claude/skills so local sessions and the PR review agent share the same wording and minimal-code rules. The review prompt reads both and reports one line per finding.
|
Reviewed full diff (CI gate fix + skill vendoring + doc updates). Checked against earlier review comment: sleep-30 finding already addressed (now sleep 10 with rationale), not re-raised. [minor]
[nit]
Correctness/security: no bugs found. Ready for human review. |
The last run posted its review but exceeded the 30 turn cap (38 turns, 11 tool denials). Raise the cap to 50 and allow read-only git diff, log and show so the agent does not burn turns on denied calls. Also add the MIT license text next to the vendored caveman skill and record the skills in ADR-0008, both review findings.
|
Addressed: PR retitled to cover both changes, ADR-0008 now records the skills, MIT license text added next to the vendored caveman skill. Kept the caveman SKILL.md verbatim on purpose (intensity tiers included) so it stays diffable against upstream; trimming it would make future syncs manual. |
|
Reviewed full diff (4 commits). Checked against both earlier reviews: sleep-10 delay, self-exclusion filter, ADR-0008 skills wording, MIT license text, and PR retitle all confirmed addressed. Wenyan tiers kept verbatim per maintainer's diffability rationale, not re-raised. New material since last review (commit 4: max-turns bump, git diff/log/show tools, LICENSE file): no correctness or security issues. Turn cap raise and read-only git tools tie to observed failure (38 turns, 11 denials in prior run), not speculative scope. [nit]
Ready for human review. |
Summary
wait-for-checksjob now pollsactions/runs?head_sha=<PR head>and waits until every workflow run exceptClaude PR Reviewitself is complete; the review runs only if all are success/neutral/skipped.actions: readreplaceschecks: read.Closes #404 (follow-up of #351)
Test plan