add permission claims to APIServices apis - #290
Closed
cnvergence wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
mjudeikis
reviewed
Aug 21, 2025
Comment on lines
+169
to
+172
| metav1.LabelSelector `json:",inline"` | ||
|
|
||
| // matchAll grants access to all objects of the claimed resource. | ||
| MatchAll bool `json:"matchAll,omitempty"` |
Contributor
There was a problem hiding this comment.
These will be mutually exclusive? same as in kcp?
mjudeikis
reviewed
Aug 21, 2025
| IsolationNone Isolation = "None" | ||
|
|
||
| // Cluster-wide isolation for cluster-scoped resources. | ||
| IsolationCluster Isolation = "Cluster" |
Contributor
There was a problem hiding this comment.
Where this one came from?
mjudeikis
reviewed
Aug 21, 2025
| // | ||
| // +kubebuilder:default="" | ||
| // +optional | ||
| IdentityHash string `json:"identityHash,omitempty"` |
mjudeikis
reviewed
Aug 21, 2025
mjudeikis
left a comment
mjudeikis
left a comment
Contributor
There was a problem hiding this comment.
Can you add pseudo yaml files now they would look like?
Request, export and binding?
Where does logic for permissions will live?
Member
Author
|
Closed in favor of #304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
Related Issue(s)
Fixes #
Release Notes