WIP: Move shards object ownership to shards - #4337
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
31e1709 to
dd7008d
Compare
dd7008d to
6f00c20
Compare
|
Pending item is: I think this need small write-up before we process further. |
|
@mjudeikis: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR moves shard object authoritative data into the shards themselves. And the root shard only sees a shallow copy.
This is part of a bigger effort to reduce root shard dependency #4336
Not yet sure if this gonna work in the form it is now :)
IMPORTANT: This removed ability to make shards
unschedulablevia annotation. Need to see if this still right place for it. Because shards are "owning their own objects", we need two way communication for this.What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #
Release Notes