Skip to content

WIP: Move shards object ownership to shards - #4337

Open
mjudeikis wants to merge 4 commits into
kcp-dev:mainfrom
mjudeikis:shard-decoupling
Open

WIP: Move shards object ownership to shards#4337
mjudeikis wants to merge 4 commits into
kcp-dev:mainfrom
mjudeikis:shard-decoupling

Conversation

@mjudeikis

@mjudeikis mjudeikis commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR moves shard object authoritative data into the shards themselves. And the root shard only sees a shallow copy.
This is part of a bigger effort to reduce root shard dependency #4336

Not yet sure if this gonna work in the form it is now :)

IMPORTANT: This removed ability to make shards unschedulable via annotation. Need to see if this still right place for it. Because shards are "owning their own objects", we need two way communication for this.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #

Release Notes

Move shard authoritive data into shards itself

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Aug 21, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 21, 2026
@mjudeikis

Copy link
Copy Markdown
Contributor Author

/retest

@mjudeikis

Copy link
Copy Markdown
Contributor Author

Pending item is:
How we model operations now - scheduling, not scheduling, limits in this model

I think this need small write-up before we process further.

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

@mjudeikis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-multiple-runs 6f00c20 link true /test pull-kcp-test-e2e-multiple-runs

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants