Skip to content

e2e: add API conversion webhook test for APIBindings - #4339

Open
gman0 wants to merge 1 commit into
kcp-dev:mainfrom
gman0:e2e-api-lifecycle
Open

e2e: add API conversion webhook test for APIBindings#4339
gman0 wants to merge 1 commit into
kcp-dev:mainfrom
gman0:e2e-api-lifecycle

Conversation

@gman0

@gman0 gman0 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an e2e test for conversion webhook + APIBinding.

What Type of PR Is This?

/kind feature

Related Issue(s)

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Aug 24, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ntnn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gman0 gman0 changed the title e2e: add API conversion webhook test e2e: add API conversion webhook test for APIBindings Aug 24, 2026
@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 24, 2026
@gman0
gman0 force-pushed the e2e-api-lifecycle branch from a0e832f to d94d54a Compare August 24, 2026 13:29
On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0

gman0 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Interesting failures in GC 🤔

Three jobs failed in TestGarbageCollectorTypesFromBinding. I'm somewhat lucky reproducing this locally with running TestAPILifecycleWithVersionMigration followed by TestGarbageCollectorTypesFromBinding. Something is stuck after the API migration.

@gman0

gman0 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

@gman0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-sharded-embedded-vw 4692267 link false /test pull-kcp-test-e2e-sharded-embedded-vw
pull-kcp-test-e2e-sharded 4692267 link true /test pull-kcp-test-e2e-sharded

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gman0

gman0 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

/hold do-not-merge

Investigating interaction between API migration and GC.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants