chore(deps): update#454
Conversation
| fn timed_println(msg: String) { | ||
| let now = SystemTime::now(); | ||
| let formatted_time = humantime::format_rfc3339(now); | ||
| let formatted_time = jiff::Timestamp::now().to_string(); |
There was a problem hiding this comment.
This produces
2026-04-05T19:18:51.276776100Z
instead of before
2026-04-05T19:18:51.276776Z
... which I don't think its a problem necessarily.
There was a problem hiding this comment.
Like you mentioned, it's not a problem. I.e. I don't think we need to introduce jiff, which brings in more dependencies. humantime has no dependency.
There was a problem hiding this comment.
I swapped humantime with jiff because its being used in the latest release of env_logger, so its actually one less dependency.
There was a problem hiding this comment.
Got it. Since env_logger is for testing only, I think it's OK for it staying with the current version. Can you please remove the update for env_logger, and hence no need to add jiff ?
The rest LGTM. Thanks!
There was a problem hiding this comment.
The replacement of humantime has been done in 0.11.7, so I've pinned the version to 0.11.6, please mention if I should roll it back completely anyways.
CosminPerRam
force-pushed
the
chore_update_deps
branch
from
14d3f3b to
4d12660
Compare
2 participants
Also removes
test-log-macrosas we are on1.71now.Not sure why we had
fastranddefined again in dev-deps (as its already in deps), #455 removes its usage in tests.