Allow passing cors options - #70
Open
tom-sherman wants to merge 1 commit into
Open
Conversation
kenneth-gray
requested changes
Apr 8, 2024
kenneth-gray
left a comment
kenneth-gray
left a comment
Owner
There was a problem hiding this comment.
Cheers Tom - I've actually been off work/personal programming for about 6 months and have just come back to it recently.
Just the one change request on the type (see specific comment). I also need to add a deprecation notice to this repo, but for the sake of making life easier we'll get this one into this repo.
| resetScenariosPath?: string; | ||
| scenariosPath?: string; | ||
| cookieMode?: boolean; | ||
| cors?: CorsOptions; |
Owner
There was a problem hiding this comment.
I've purposefully resisted using types from libraries in case I want to change the underlying technology. Wonder if we could just copy the relevant type in this instance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.