feat: device locale helpers, privacy string accessors, and rule triggers - #139
Open
ethanpschoen wants to merge 6 commits into
Open
feat: device locale helpers, privacy string accessors, and rule triggers#139ethanpschoen wants to merge 6 commits into
ethanpschoen wants to merge 6 commits into
Conversation
Extracts the raw device-locale lookup and a BCP-47 formatter into their own module, replacing the module-level deviceLanguage const in the provider. Pure refactor, no behavior change. Part 1/5 of the split of #126.
Adds accessors for the IAB privacy strings the tag writes to native storage (TCF TC string, US Privacy string, GPP header string) and a generic getSavedString helper. The util barrel export also picks up the device-locale module from the prior PR in this stack, since both additions land in the same import block. Part 2/5 of the split of #126.
ethanpschoen
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 590fde6. Configure here.
This was referenced Aug 6, 2026
ethanpschoen
marked this pull request as ready for review
August 6, 2026 20:59
8 tasks
getSavedString and the IAB helpers always read through nativeStorage.read, so they never saw values persisted via a custom preferenceStorage backend. That backend is required for Expo Android in the README, and on that setup crossPlatformRead falls back to React Native Settings, which is a no-op on Android — so these accessors returned empty strings after consent updates whenever preferenceStorage was configured. This PR adds the capability (an optional reader parameter, defaulting to the existing nativeStorage.read). The provider wiring that actually builds a reader from the configured preferenceStorage and binds these accessors to it lands in #141, alongside the rest of the KetchService exposure. Refs #126.
Adds an imperative trigger() method that fires an onFunction rule trigger and queues until the tag's config has loaded, plus enum values for normalizing the hide/show experience callbacks. onHideExperience now receives a normalized enum, falling back to none, instead of the raw tag payload. Also carries the ketch_mobilesdk_url URL-param override, which lives in the same helpers.ts region as the new trigger helpers. Part 3/5 of the split of #126.
The webViewMountKey reset effect nulled the pending trigger on every mount-key change, including the async ATT-driven change that always fires once on iOS before the WebView's first mount. trigger() had already returned true by then, so the call was silently swallowed instead of firing once the tag booted. Refs #126.
getDeviceLanguage() returns the raw platform identifier, underscore-separated on Android (en_US) and on iOS whenever AppleLocale is used. Every default-configured install therefore sent language=en_US to both the headless CDN client and the WebView, since the headless client's own BCP-47 formatting is only reached when languageCode is falsy — and the provider always supplied one. Refs #126.
ethanpschoen
force-pushed
the
ethanpschoen/feat/rule-triggers
branch
from
August 6, 2026 21:22
590fde6 to
738c2b1
Compare
ethanpschoen
changed the title
ethanpschoen
changed the title
ethanpschoen
changed the title
ethanpschoen
changed the base branch from
ethanpschoen/feat/privacy-string-accessors
to
main
August 7, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of this change
Bottom layer of a 2-PR stack for the headless SDK surface. Review this PR's diff against
main.languageCodeto a BCP-47 device locale tagtrigger()call across a WebView remountWhy is this change being made?
How was this tested? How can the reviewer verify your testing?
Related issues
None.
Checklist