fix(keyboard): normalize fn key rendering - #131
Closed
esphynox wants to merge 6 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix duplicate and inconsistent
fnrendering by moving it to a single state-driven path.command/shift/option/controlfnfromflagsChangedstate updates instead of treating it like a normal chord modifier.functionkeystroke rendering and retain the activefngroup through release so it does not duplicatefnpress/release and transformed-key behaviorTests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/KeyboardVisualizerTests -only-testing:KeytyTests/KeycapItemFactoryTestsRun project commands from
Apps/Keyty.UI Changes
Attach screenshots or screen recordings for visible UI changes. Write
N/Aif there are none.Documentation
Release Notes
Fix duplicated and inconsistent
fnkey rendering in the keyboard visualizer.