Skip to content

fix(keyboard): normalize fn key rendering - #131

Closed
esphynox wants to merge 6 commits into
mainfrom
fix/fn-key-duplicate-display
Closed

fix(keyboard): normalize fn key rendering#131
esphynox wants to merge 6 commits into
mainfrom
fix/fn-key-duplicate-display

Conversation

@esphynox

@esphynox esphynox commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix duplicate and inconsistent fn rendering by moving it to a single state-driven path.

  • keep classical modifier handling limited to command/shift/option/control
  • render physical fn from flagsChanged state updates instead of treating it like a normal chord modifier
  • suppress .function keystroke rendering and retain the active fn group through release so it does not duplicate
  • add focused keyboard visualizer coverage for fn press/release and transformed-key behavior

Tests

  • tuist generate
  • xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'
  • Other:
    • xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/KeyboardVisualizerTests -only-testing:KeytyTests/KeycapItemFactoryTests

Run project commands from Apps/Keyty.

UI Changes

Attach screenshots or screen recordings for visible UI changes. Write N/A if there are none.

Before After
N/A N/A

Documentation

  • Updated relevant docs
  • No docs needed

Release Notes

Fix duplicated and inconsistent fn key rendering in the keyboard visualizer.

@esphynox esphynox added the bug Something isn't working label Aug 25, 2026
@esphynox esphynox self-assigned this Aug 25, 2026
@esphynox esphynox closed this Aug 25, 2026
@esphynox
esphynox deleted the fix/fn-key-duplicate-display branch August 25, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant