fix(keyboard): render fn as a single keycap - #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix duplicate and inconsistent
fnrendering by moving it to a single state-driven path.Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'— 301 tests, 0 failurestuist generatenot needed — no change toProject.swift, dependencies, build settings, resources, or project structureUI Changes
No screenshots attached, but there are two visible changes:
fnpress now shows one keycap that lights on press and dims on release,instead of two separate keycaps.
fnpicks up the special-key theme instead of the modifier theme, following from it nolonger sitting in the modifier row. Say the word if the modifier colors should be kept
and the category mapping can be restored on its own.
Documentation
Release Notes
Pressing
fnnow shows a single keycap instead of rendering it twice, and it is styledlike the other special keys.