Refactor samples.tsv schema: explicit input_type column and output_bids_dataset support#74
Draft
Copilot wants to merge 3 commits intodev-v0.2.0from
Draft
Refactor samples.tsv schema: explicit input_type column and output_bids_dataset support#74Copilot wants to merge 3 commits intodev-v0.2.0from
Copilot wants to merge 3 commits intodev-v0.2.0from
Conversation
… replace acq substring matching with explicit wildcard_constraints routing Agent-Logs-Url: https://github.com/khanlab/SPIMprep/sessions/91f24ab5-f565-4a53-8e6f-33d6d4b26771 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
…g regex Agent-Logs-Url: https://github.com/khanlab/SPIMprep/sessions/91f24ab5-f565-4a53-8e6f-33d6d4b26771 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor to support multiple BIDS datasets and improve workflow selection
Refactor samples.tsv schema: explicit input_type column and output_bids_dataset support
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow selection was implicitly derived from
acqsubstrings (e.g.,{acq,[a-zA-Z0-9]*blaze[a-zA-Z0-9]*}), making it fragile and unintuitive. A singlerootoutput path also prevented multi-dataset workflows.Schema changes
samples.tsvgains two new columns:input_typeblaze|prestitched|imarisoutput_bids_datasetRouting refactor
{acq,[a-zA-Z0-9]*blaze[a-zA-Z0-9]*}wildcard patterns withwildcard_constraintsblocks driven by the samples tableget_acq_constraint(input_type_str)— generates a per-type regex from actualacqvalues in samples; returns a never-matching regex ((?!x)x) when no samples use that typeget_output_ome_zarr()no longer takes anacq_typeargument; each calling rule declares its own constraintoutput_bids_datasetsupportrootconfig before rules loadValueErrorwith a message pointing to future per-sample routing supportCLI
--input-type {blaze,prestitched,imaris}(default:blaze) so the single-samplerun.pypath also sets the column explicitlyBug fix
imaris_to_ome_zarrwas referencingprestitched_to_metadataoutput; corrected toimaris_to_metadata.