fix(Firefox): include background.scripts in manifest.json#66
Open
nshki wants to merge 1 commit into
Open
Conversation
Firefox 152.0.4 still uses `background.scripts` for the manifest, so when trying to load `main` as-is at the moment, the browser reports `background.service_worker is currently disabled. Add background.scripts`. This change enables Firefox to successfully load the extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 152.0.4 still uses
background.scriptsfor the manifest, so when trying to loadmainas-is at the moment, the browser reportsbackground.service_worker is currently disabled. Add background.scripts. This change enables Firefox to successfully load the extension.