Refactor ai agent config - #10
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the project's documentation and agent guidelines by modularizing AGENTS.md into domain-specific rule files under .agents/rules/ and introducing comprehensive agent skill definitions (such as Hono, Bun, shadcn, and various TanStack libraries) across the monorepo. Additionally, .dockerignore is updated to exclude agent-related directories. The review feedback identifies a few minor issues: a duplicate placeholderData key in the TanStack Query skill documentation, a missing path for the root .agents/skills directory in .agents/skills.json, and a typo in .dockerignore referencing skill-lock.json instead of skills-lock.json.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| placeholderData: (previousData) => previousData, // keepPreviousData pattern | ||
| placeholderData: initialTodos, |
There was a problem hiding this comment.
The placeholderData key is defined twice in this object literal example. This duplicate key is redundant and can cause confusion or linter warnings. Consider removing one of the definitions or combining them into a single comment/example.
| placeholderData: (previousData) => previousData, // keepPreviousData pattern | |
| placeholderData: initialTodos, | |
| placeholderData: (previousData) => previousData, // keepPreviousData pattern (or use initialTodos) |
kid1412621
left a comment
kid1412621
left a comment
There was a problem hiding this comment.
I have completed the automated review of PR #10. I found several issues that need to be addressed:
- .dockerignore: Typo in lockfile name (
skill-lock.jsoninstead ofskills-lock.json). - .agents/skills.json: Path resolution issue and redundancy with the default customization root.
- client/.agents/skills/tanstack-query/SKILL.md: Duplicate
placeholderDatakeys defined in the same options object inside auseQuerycode block. - client/skills-lock.json: Mismatched
skillPathvalues for TanStack skills (contain aplugins/prefix that doesn't match their actual location). - server/skills-lock.json: Mismatched
skillPathvalues for langchain/langgraph skills (contain aconfig/prefix that doesn't match their actual location). - skills-lock.json (root): Mismatched
skillPathfor theshadcnskill, which actually resides in theclient/workspace directory.
Please see the inline comments for details on how to resolve these issues.
| .codex | ||
| AGENTS.md | ||
| CLAUDE.md | ||
| skill-lock.json |
There was a problem hiding this comment.
Incorrect filename in .dockerignore: skill-lock.json is used here, but the actual lockfiles in the repository are named skills-lock.json (e.g. client/skills-lock.json, server/skills-lock.json, and skills-lock.json at the root).
Please change this to skills-lock.json or **/skills-lock.json to properly ignore these lockfiles.
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "entries": [ | |||
| { "path": ".agents/skills" }, | |||
There was a problem hiding this comment.
Paths in .agents/skills.json might be incorrect:
.agents/skillsis already the standard customization root and is automatically discovered, so registering it here is redundant.- If the engine resolves paths in
skills.jsonrelative to the folder containing it (which is.agents/), then all of these paths will resolve to non-existent subdirectories (e.g..agents/client/.agents/skills). In that case, they should use relative paths:"skills"or"./skills""../client/.agents/skills""../server/.agents/skills"
Please verify how the path resolution is handled by the Antigravity engine and update the configuration.
| initialData: () => cachedData, | ||
| initialDataUpdatedAt: Date.now() - 10000, | ||
| placeholderData: (previousData) => previousData, // keepPreviousData pattern | ||
| placeholderData: initialTodos, |
There was a problem hiding this comment.
Duplicate key placeholderData in JS code block:
placeholderData: (previousData) => previousData, // keepPreviousData pattern
placeholderData: initialTodos,Defining placeholderData twice inside the same options object passed to useQuery is a configuration/syntax error. Please separate these examples or clean it up.
| "tanstack-devtools": { | ||
| "source": "tanstack-skills/tanstack-skills", | ||
| "sourceType": "github", | ||
| "skillPath": "plugins/tanstack-devtools/skills/tanstack-devtools/SKILL.md", |
There was a problem hiding this comment.
Incorrect skillPath values for TanStack skills:
The paths are recorded as "plugins/tanstack-devtools/skills/tanstack-devtools/SKILL.md", but the actual files in the repository are located directly at client/.agents/skills/tanstack-devtools/SKILL.md (which maps to skills/tanstack-devtools/SKILL.md relative to the client's customization root).
These should be updated to "skills/tanstack-devtools/SKILL.md", etc.
| "langchain-dependencies": { | ||
| "source": "langchain-ai/langchain-skills", | ||
| "sourceType": "github", | ||
| "skillPath": "config/skills/langchain-dependencies/SKILL.md", |
There was a problem hiding this comment.
Incorrect skillPath values for langchain/langgraph skills:
The paths are recorded with a "config/" prefix (e.g. "config/skills/langchain-dependencies/SKILL.md"), but the files are added at server/.agents/skills/langchain-dependencies/SKILL.md (which maps to "skills/langchain-dependencies/SKILL.md" relative to the server customization root).
These should be updated to "skills/langchain-dependencies/SKILL.md", etc.
| "shadcn": { | ||
| "source": "shadcn/ui", | ||
| "sourceType": "github", | ||
| "skillPath": "skills/shadcn/SKILL.md", |
There was a problem hiding this comment.
Incorrect skillPath for shadcn:
The root workspace skills-lock.json registers shadcn with path "skills/shadcn/SKILL.md", but the actual skill file is located at client/.agents/skills/shadcn/SKILL.md. If the root configuration resolves this skill via the entries in skills.json, the path should correctly point to where it actually is, or the duplicate entry in root skills-lock.json should be removed if the root workspace does not load/need the shadcn skill.
1 participant
No description provided.