refactor: rename misc/ to scripts/ for a more descriptive directory name#850
Open
kitsuyui wants to merge 1 commit into
Open
refactor: rename misc/ to scripts/ for a more descriptive directory name#850kitsuyui wants to merge 1 commit into
kitsuyui wants to merge 1 commit into
Conversation
🎉 Happy commit!
|
Code Metrics Report
Details | | main (8bad195) | #850 (6715226) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 99.2% | 99.2% | 0.0% |
| Files | 5 | 5 | 0 |
| Lines | 134 | 134 | 0 |
| Covered | 133 | 133 | 0 |
| Code to Test Ratio | 1:1.3 | 1:1.3 | 0.0 |
| Code | 723 | 723 | 0 |
| Test | 955 | 955 | 0 |
+ | Test Execution Time | 2s | 1s | -1s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
misc/directory contained a single shell script (make-lucky.sh) under a generic, non-descriptive name.misc/conveys no intent about the directory's responsibility, making it harder for contributors to understand where utility scripts live.This renames the directory to
scripts/, which is a conventional location for shell utility scripts and clearly communicates the directory's purpose.No functional changes — the script itself is unmodified.