Skip to content

Ci nginx and tagged image - #16

Merged
kjdev merged 2 commits into
mainfrom
ci/nginx-and-tagged-image
Jul 27, 2026
Merged

Ci nginx and tagged image#16
kjdev merged 2 commits into
mainfrom
ci/nginx-and-tagged-image

Conversation

@kjdev

@kjdev kjdev commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Improved Docker image tagging for releases, tagged builds, default-branch builds, and development builds.
    • Updated Nginx test coverage to validate against newer stable and mainline versions.

kjdev added 2 commits July 27, 2026 08:34
Allow package.yaml to tag the pushed image with the selected git tag
name when workflow_dispatch is triggered via the "Use workflow from"
tag selector, instead of always falling back to dev-<sha>.
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

GitHub Actions Docker image tagging now distinguishes release events, tag refs, default-branch builds, and development builds. The Nginx test matrix updates its stable and mainline versions.

Changes

Workflow Updates

Layer / File(s) Summary
Docker image tag selection
.github/workflows/package.yaml
Docker image tags and the manifest TAG now derive from release tag names, explicit tag refs, the default branch, or dev-<sha>.
Nginx test matrix versions
.github/workflows/test.yaml
The stable Nginx version changes to 1.30.4, and the mainline version changes to 1.31.3.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main changes: Nginx CI version bumps and tagged image handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/nginx-and-tagged-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjdev

kjdev commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/package.yaml:
- Line 49: Update the image-tag computation used by the workflow’s build and
index steps to validate or normalize release and Git tag names against OCI tag
rules, rejecting or safely transforming values containing characters such as
“/”. Reuse the same validated tag for both tools/build-push-action tags and
docker buildx imagetools create so per-architecture builds and index creation
remain consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4937cffa-3453-49b3-9434-bb2f0ed5cb13

📥 Commits

Reviewing files that changed from the base of the PR and between 2c51eef and 56ab9d6.

📒 Files selected for processing (2)
  • .github/workflows/package.yaml
  • .github/workflows/test.yaml

Comment thread .github/workflows/package.yaml
@kjdev
kjdev merged commit 56ab9d6 into main Jul 27, 2026
7 checks passed
@kjdev
kjdev deleted the ci/nginx-and-tagged-image branch July 27, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant