Ci nginx and tagged image - #16
Conversation
Allow package.yaml to tag the pushed image with the selected git tag name when workflow_dispatch is triggered via the "Use workflow from" tag selector, instead of always falling back to dev-<sha>.
📝 WalkthroughWalkthroughGitHub Actions Docker image tagging now distinguishes release events, tag refs, default-branch builds, and development builds. The Nginx test matrix updates its stable and mainline versions. ChangesWorkflow Updates
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/package.yaml:
- Line 49: Update the image-tag computation used by the workflow’s build and
index steps to validate or normalize release and Git tag names against OCI tag
rules, rejecting or safely transforming values containing characters such as
“/”. Reuse the same validated tag for both tools/build-push-action tags and
docker buildx imagetools create so per-architecture builds and index creation
remain consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4937cffa-3453-49b3-9434-bb2f0ed5cb13
📒 Files selected for processing (2)
.github/workflows/package.yaml.github/workflows/test.yaml
Summary by CodeRabbit