chore: pin line endings and editor defaults - #50
Merged
Conversation
Adds `.gitattributes` and `.editorconfig`, which the repository has been without. `* text=auto eol=lf` makes the checkout independent of each contributor's `core.autocrlf`. Until now a Windows checkout produced a CRLF working tree while the repository stored LF, so the two disagreed and any tool that compares line endings reported differences that were not really there. Binary types are marked so git never rewrites them. `.editorconfig` states the conventions the sources already follow — UTF-8, LF, two-space indent, a final newline, no trailing whitespace — so an editor applies them without per-contributor configuration. No file contents change: everything committed was already LF, so `git add --renormalize` produces no diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two files the repository has been without:
.gitattributesand.editorconfig.Why
Line endings depended on each contributor's git configuration. The repository
stores LF, but with
core.autocrlf=true— the default on Windows — a checkoutproduces a CRLF working tree. The two then disagree, and any tool that compares
line endings reports differences that are not really there.
* text=auto eol=lfremoves that dependency: the working tree is LF everywhere, regardless of how a
contributor's git is configured.
Binary types are marked so git never rewrites them.
.editorconfigstates conventions the sources already follow — UTF-8, LF,two-space indent, a final newline, no trailing whitespace. Editors apply them
without each contributor configuring anything.
No content changes
Everything committed was already LF, so
git add --renormalize .produces nodiff. This pull request adds files and changes none.