feat!: bump the npm-minor-patch group, raising engines.vscode to ^1.134.0 - #27
Merged
kkdev92 merged 2 commits intoAug 28, 2026
Merged
Conversation
Bumps the npm-minor-patch group with 3 updates: [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode), [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@types/vscode` from 1.125.0 to 1.134.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode) Updates `@vitest/coverage-v8` from 4.1.10 to 4.1.11 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.11/packages/coverage-v8) Updates `vitest` from 4.1.10 to 4.1.11 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.11/packages/vitest) --- updated-dependencies: - dependency-name: "@types/vscode" dependency-version: 1.134.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: "@vitest/coverage-v8" dependency-version: 4.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: vitest dependency-version: 4.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
The grouped dependency update moved `@types/vscode` to 1.134.0 and left `engines.vscode` at `^1.125.0`, so `vsce package` refused the build: @types/vscode ~1.134.0 greater than engines.vscode ^1.125.0. Either upgrade engines.vscode or use an older @types/vscode version The check compares major and minor only and has no bypass flag, and it is right: types above the floor let code compile against an API the declared minimum does not have. So the two move together rather than pinning the types back. While updating the version prose, two facts in CONTRIBUTING.md turned out to be stale independently of this change: it asked for Node.js >= 22.12 where `engines.node` and every CI job require 24, and it attributed the VS Code floor to `@kkdev92/vscode-ext-kit` 2.0 when the dependency has been `^3.0.0` for some time. Both corrected. Verified locally, all exit 0: typecheck, lint, check:l10n, unit + integration tests, `vsce package`, verify:vsix, and the real Extension Host lane (13 cases, VS Code 1.135.0). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kkdev92
changed the title
dependabot
Bot
deleted the
dependabot/npm_and_yarn/npm-minor-patch-20d717b227
branch
August 28, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's grouped update, plus the change it needs to be correct.
Why it could not be merged as-is
The bot raised
@types/vscodeto 1.134.0 and leftengines.vscodeat^1.125.0, so thepackagejob failed:That is
validateVSCodeTypesCompatibilityinvsce(src/validation.ts). Itcompares major and minor only, ignores the patch because DefinitelyTyped
auto-increments it, and has no bypass flag.
The rule is right: types above the floor let code compile against an API the
declared minimum does not have.
What this PR does
Raises
engines.vscodeto^1.134.0so the two move together.Breaking: the minimum supported VS Code moves from 1.125 to 1.134.
Installations older than that keep the version they have and stop receiving
updates.
DefinitelyTyped had been stuck at 1.125.0 for months against a stable line
already past 1.131. It is now at 1.134.0 — one release behind the current
stable 1.135.
Verification
Local, all exit 0:
typecheck,lint,check:l10n, unit + integration tests (35),vsce package,verify:vsix, and the real Extension Host lane — 13 cases on VS Code 1.135.0.Also in this PR:
CONTRIBUTING.mdasked for Node.js ≥ 22.12 whereengines.nodeand every CI job require 24, and credited the VS Code floor to@kkdev92/vscode-ext-kit2.0 when the dependency has been^3.0.0for some time. Both were already stale; corrected here since the same lines needed the version change.Note
No version bump or release is included. The entry sits under
[Unreleased];cutting a release is a separate decision.