chore(deps): vscode-ext-kit 4.0.0 - #31
Merged
Merged
Conversation
The framework raised its own engines.vscode to ^1.134.0, which this extension already declares. `^3.0.0` does not pick up a major, so the two had drifted: the extension required more than the library it is built on. The bundle was built against both versions and compared: exactly one byte of 348,529 differs, and it is meant to. `KIT_VERSION` in src/core/build.ts is inlined at bundle time so the state report can name the kit a build was actually compiled against rather than the semver range -- it now correctly reports 4.0.0. Nothing else moves. Verified: lint, typecheck, check:l10n, 236 unit + 35 integration tests, vsce package, verify:vsix, and the real Extension Host lane (13 cases, VS Code 1.135.0). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kkdev92/vscode-ext-kit^3.0.0→^4.0.0.The framework raised its own
engines.vscodeto^1.134.0— which this extension already declares.^3.0.0does not pick up a major, so the two had drifted apart: the extension required a newer VS Code than the library it is built on.Exactly one byte of the bundle changes, and it is meant to
Measured rather than asserted. The bundle was built against both kit versions and compared:
That is
src/core/build.ts, which the build inlines through esbuild'sdefineprecisely so the state report names the kit a build was actually compiled against, rather than the semver range. It reported3.0.0before and now reports4.0.0— which is the value being correct, not drifting.Nothing else moves:
.d.tsis identical across all 105 files, and the only differing runtime files in the published kit aretesting/fakes/fake-filewatcher, reached via the./testingsubpath and never bundled.No release is needed — the entry sits under
[Unreleased].Verification
Local, all exit 0:
lint,typecheck,check:l10n, 236 unit + 35 integration tests,vsce package,verify:vsix, and the real Extension Host lane — 13 cases on VS Code 1.135.0.