Fix particle_clip_cells for NCLaw shape scenes - #3
Open
chhsiao93 wants to merge 1 commit into
Open
Conversation
…s, but bunny/blub/spot use sim.bound (3) and armadillo uses 1
NCLaw's own nclaw_bc grid semantics were being replayed with a single
particle_clip_cells=0.5 for every scene, matching every material's base
env/blob/*.yaml. But their mesh-shape configs (bunny.yaml, blub.yaml,
spot.yaml) override clip_bound to ${sim.bound} (3 at both the low and
high quality presets used here), and armadillo.yaml fixes it at 1.
Missing this let our rollouts settle roughly one grid cell past NCLaw's
actual floor on plasticine/sand/water's shape scenes -- confirmed by
comparing settled particle height against both engines' own grid_op_freeslip
kernels (identical index arithmetic) and against NCLaw's own advection clamp
(nclaw/sim/mpm.py, new_x = wp.clamp(new_x, bound, 1-bound)). It was the sole
cause of those scenes diverging hard from NCLaw's own trajectory even when
seeded from the exact truth parameters: plasticine/shape_bunny's truth-theta
MSE went from 2.7e-04 to 6.0e-11 (full tier) after this fix, in line with
every other scene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
particle_clip_cellswas 0.5 for all scenes, but bunny/blub/spot use sim.bound (3) and armadillo uses 1NCLaw's own nclaw_bc grid semantics were being replayed with a single particle_clip_cells=0.5 for every scene, matching every material's base env/blob/*.yaml. But their mesh-shape configs (bunny.yaml, blub.yaml, spot.yaml) override clip_bound to ${sim.bound} (3 at both the low and high quality presets used here), and armadillo.yaml fixes it at 1.
Missing this let our rollouts settle roughly one grid cell past NCLaw's actual floor on plasticine/sand/water's shape scenes -- confirmed by comparing settled particle height against both engines' own grid_op_freeslip kernels (identical index arithmetic) and against NCLaw's own advection clamp (nclaw/sim/mpm.py, new_x = wp.clamp(new_x, bound, 1-bound)). It was the sole cause of those scenes diverging hard from NCLaw's own trajectory even when seeded from the exact truth parameters: plasticine/shape_bunny's truth-theta MSE went from 2.7e-04 to 6.0e-11 (full tier) after this fix, in line with every other scene.