Skip to content

Document drm_dma_helper dependency for loading fl2000 - #85

Open
NhlalukoG wants to merge 1 commit into
klogg:masterfrom
NhlalukoG:docs/load-drm-dma-helper
Open

Document drm_dma_helper dependency for loading fl2000#85
NhlalukoG wants to merge 1 commit into
klogg:masterfrom
NhlalukoG:docs/load-drm-dma-helper

Conversation

@NhlalukoG

Copy link
Copy Markdown

Summary

  • Document that fl2000 depends on drm_dma_helper and must have it loaded before insmod, since insmod does not resolve module dependencies.
  • Reorder the README so DRM helpers are loaded before inserting the driver modules.
  • Fix the ./scritps/sign.sh typo to ./scripts/sign.sh.

Without drm_dma_helper, loading fails with unknown symbols such as drm_fb_dma_get_gem_obj / drm_gem_dma_dumb_create.

Test plan

  • Follow the updated README on a clean boot (without drm_dma_helper already loaded)
  • Confirm modprobe drm_dma_helper then insmod fl2000.ko && insmod it66121.ko succeeds
  • Confirm lsmod shows fl2000 depending on drm_dma_helper

Made with Cursor

insmod does not pull in module dependencies, so fl2000 fails with unknown DRM DMA symbols unless drm_dma_helper is loaded first. Also fix the sign.sh path typo.

Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to correct the setup instructions, including adding drm_dma_helper to the required DRM components and fixing a typo in the signing script path. The review feedback recommends reordering the instructions so that kernel module signing is performed before attempting to load the modules when secure boot is enabled, and suggests running the signing script with sudo.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md
Comment on lines +22 to 29
Then use
```
./scritps/sign.sh
insmod fl2000.ko && insmod it66121.ko
```
ensure that DRM components are loaded in your system, if not - please use
with sudo or in root shell to start the driver. If you are running on a system with secure boot enabled, you may need to sign kernel modules. Try using provided script for this:
```
modprobe drm
modprobe drm_kms_helper
./scripts/sign.sh
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If secure boot is enabled, the kernel modules must be signed before attempting to load them with insmod, otherwise the load will fail immediately. Additionally, the signing script accesses /var/lib/shim-signed/mok, which typically requires root privileges, so it should be run with sudo.

Suggested reordering:

If you are running on a system with secure boot enabled, you may need to sign the kernel modules first. Try using the provided script for this (usually requires sudo):

sudo ./scripts/sign.sh

Then use:

sudo insmod fl2000.ko && sudo insmod it66121.ko

to start the driver (or run in a root shell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant