Document drm_dma_helper dependency for loading fl2000 - #85
Conversation
insmod does not pull in module dependencies, so fl2000 fails with unknown DRM DMA symbols unless drm_dma_helper is loaded first. Also fix the sign.sh path typo. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to correct the setup instructions, including adding drm_dma_helper to the required DRM components and fixing a typo in the signing script path. The review feedback recommends reordering the instructions so that kernel module signing is performed before attempting to load the modules when secure boot is enabled, and suggests running the signing script with sudo.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| Then use | ||
| ``` | ||
| ./scritps/sign.sh | ||
| insmod fl2000.ko && insmod it66121.ko | ||
| ``` | ||
| ensure that DRM components are loaded in your system, if not - please use | ||
| with sudo or in root shell to start the driver. If you are running on a system with secure boot enabled, you may need to sign kernel modules. Try using provided script for this: | ||
| ``` | ||
| modprobe drm | ||
| modprobe drm_kms_helper | ||
| ./scripts/sign.sh | ||
| ``` |
There was a problem hiding this comment.
If secure boot is enabled, the kernel modules must be signed before attempting to load them with insmod, otherwise the load will fail immediately. Additionally, the signing script accesses /var/lib/shim-signed/mok, which typically requires root privileges, so it should be run with sudo.
Suggested reordering:
If you are running on a system with secure boot enabled, you may need to sign the kernel modules first. Try using the provided script for this (usually requires sudo):
sudo ./scripts/sign.shThen use:
sudo insmod fl2000.ko && sudo insmod it66121.koto start the driver (or run in a root shell).
Summary
fl2000depends ondrm_dma_helperand must have it loaded beforeinsmod, sinceinsmoddoes not resolve module dependencies../scritps/sign.shtypo to./scripts/sign.sh.Without
drm_dma_helper, loading fails with unknown symbols such asdrm_fb_dma_get_gem_obj/drm_gem_dma_dumb_create.Test plan
drm_dma_helperalready loaded)modprobe drm_dma_helpertheninsmod fl2000.ko && insmod it66121.kosucceedslsmodshowsfl2000depending ondrm_dma_helperMade with Cursor