fix: require app in entry, hide workspaces without pat, remove star important.#86
Merged
knightedcodemonkey merged 5 commits intonextfrom Apr 19, 2026
Merged
fix: require app in entry, hide workspaces without pat, remove star important.#86knightedcodemonkey merged 5 commits intonextfrom
knightedcodemonkey merged 5 commits intonextfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the preview entry contract to require an explicit App component, adjusts GitHub/BYOT UI visibility (notably hiding Workspaces until a PAT is available), and removes !important from [hidden] CSS rules while updating Playwright coverage to match the new behavior.
Changes:
- Remove auto-render “implicit App” wrapping so missing
Appconsistently surfaces an App-only error. - Hide Workspaces controls by default and drive toggle visibility via PAT/PR-context state.
- Simplify
[hidden]CSS rules (drop!important) and update Playwright helpers/tests for the new UI/runtime behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/diagnostics.css | Adds [hidden] handling for .diagnostics-toggle. |
| src/styles/ai-controls.css | Removes !important from multiple [hidden] rules; adds additional toggle hidden selectors. |
| src/modules/preview/render-runtime.js | Removes implicit-App auto-render wrapping and related JSX top-level metadata logic. |
| src/modules/app-core/workspace-tabs-renderer.js | Removes editor sync call from workspace tabs rendering flow. |
| src/modules/app-core/workspace-controllers-setup.js | Removes the now-unneeded delegate wiring for editor sync from active tab. |
| src/modules/app-core/github-workflows.js | Stops directly hiding Workspaces toggle on PR context change (delegates to PR context UI). |
| src/modules/app-core/github-pr-context-ui.js | Uses .hidden property to show/hide toggles and incorporates Workspaces visibility rules. |
| src/index.html | Sets Workspaces toggle to hidden by default. |
| playwright/rendering-modes.spec.ts | Updates expectations: auto-render no longer implicitly creates App; tests now expect App-only error unless App is explicit. |
| playwright/helpers/app-test-helpers.ts | Adds a more robust editor content replacement helper and waits for editor regions to be visible. |
| playwright/github-byot-ai.spec.ts | Adds assertions for Workspaces toggle hidden/visible states based on token connection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.