fix(KNO-14505): handle guide engagement API failures - #1053
Merged
thomaswhyyou merged 3 commits intoAug 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5ec9623 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle ReportChanges will increase total bundle size by 845 bytes (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @knocklabs/client-client-esmAssets Changed:
Files in
view changes for bundle: @knocklabs/client-client-cjsAssets Changed:
Files in
|
Revert the UserClient.handleResponse change and its test. The guide engagement catch handlers only log error.message, and the underlying ApiRequestError already stringifies with its HTTP status, so preserving the original error object bought nothing at the call site. Dropping it also avoids incidentally changing the thrown error shape for the other UserClient methods (identify, setPreferences, getChannelData, and friends), keeping this patch limited to the unhandled rejection. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
thomaswhyyou
force-pushed
the
kyle-kno-14505-sdk-prevent-guide-engagement-api-failures-from-becoming
branch
from
August 3, 2026 21:37
eabb87c to
5ec9623
Compare
thomaswhyyou
marked this pull request as ready for review
August 3, 2026 21:43
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 73.00% 73.06% +0.05%
==========================================
Files 139 139
Lines 4342 4351 +9
Branches 1275 1278 +3
==========================================
+ Hits 3170 3179 +9
Misses 1055 1055
Partials 117 117
|
thomaswhyyou
approved these changes
Aug 3, 2026
thomaswhyyou
deleted the
kyle-kno-14505-sdk-prevent-guide-engagement-api-failures-from-becoming
branch
August 3, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UserClientnow throws the original API error with its HTTP status and response data.Release
@knocklabs/clientand@knocklabs/react.Validation
Checklist