data: refresh UFC datasets through 2026-06-27 - #11
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
komaksym
left a comment
There was a problem hiding this comment.
Review verdict: changes required before merge.
- The deduplication removes a legitimate historical bout.
The base raw dataset contains two distinct Kazushi Sakuraba vs. Marcus Silveira bouts at UFC - Ultimate Japan on 21/12/1997: the first was recorded as no_contest / Overturned, and the rematch was red_win / Submission. The refresh deduplicates on only (red_fighter_name, blue_fighter_name, event_date, event_name), so it collapses those two real fights into one. This is why the scrape adds 146 new identity keys but stats_raw.csv grows by only 145 rows.
Please restore both bouts and use a true bout identifier—preferably the UFCStats fight-detail ID/URL. If that is unavailable, the identity must include a bout discriminator such as method, round, time, or an explicit occurrence index. Fighter pair + event + date is not unique.
- The refreshed processed datasets are largely missing fighter features.
For the 146 new fights, only 19 rows have the full static fighter-feature block populated for both fighters. In 121 rows, at least one fighter has the entire height/reach/stance/career-stat block missing; in 62 rows, both fighters are entirely missing that block. Consequently, most new rows in stats_processed.csv have blank stance and blank height/reach/career-stat delta features.
Please refresh data/external_data/raw_fighter_details.csv (or the equivalent fighter-details source) before rebuilding stats_processed_all_bouts.csv and stats_processed.csv. Otherwise these files should not be presented as fully refreshed analytical outputs.
What passed the audit:
- all four schemas are unchanged;
- 146 genuinely new bout identities across 12 events were added;
- no other historical raw fight values changed;
- existing scorecard values were preserved exactly;
- output cardinalities are internally consistent;
- both processed files reproduce exactly from the currently committed raw and fighter-details inputs.
1e211bd to
cfa0014
Compare
cfa0014 to
86d4b04
Compare
|
AI-generated response: The earlier review comment on this PR was produced by ChatGPT acting on Maksym's behalf. Future comments I post on this PR will be explicitly labeled as AI-generated. |
86d4b04 to
8524e13
Compare
komaksym
left a comment
There was a problem hiding this comment.
AI-generated response: Final re-review completed on the cleaned, one-commit branch.
No remaining blocking findings.
Verified:
- exactly 146 new fights across 12 events, through 2026-06-27;
- raw dataset contains 8,737 fights;
- no historical raw fight rows or values were removed or changed;
- both same-event Sakuraba vs. Silveira bouts are preserved;
- all 286 fighters appearing in the new bouts have profile rows;
- no new processed row is missing an entire fighter-feature block;
- existing scorecard values are unchanged;
- processed outputs are exactly reproducible from the committed inputs;
- data-processing tests pass: 6 passed;
- branch is one commit ahead of
mainand changes only the seven documented files.
Known, documented limitation: scorecards for newly added fights were not scraped/OCR-processed, so those new scorecard fields remain empty.
PR #11 is ready for human review. It has not been merged.
Summary
stats_raw.csvto 8,737 fights.Updated files
data/external_data/raw_fighter_details.csvdata/stats/stats_raw.csvdata/stats/stats_processed.csvdata/stats/stats_processed_all_bouts.csvdata/merged_stats_n_scorecards/merged_stats_n_scorecards.csvsrc/data_processing/stats_update.pytests/data_processing/test_stats_update.pyValidation
mainand changes only the seven files listed above.Scorecard note
Scorecards for the newly added fights were not scraped and OCR-processed in this refresh, so their scorecard-total fields remain empty. Existing scorecard values were preserved exactly.
Breaking changes
None.