kindle: more robust OTA update install code - #15836
Draft
benoit-pierre wants to merge 6 commits into
Draft
Conversation
Member
Author
|
Tested and only for Kindle, but I'd like to do the same on other platforms, especially on PocketBook to work around #15802. |
Member
|
Random thought: if the issue stemmed from a crash on startup, would just checking for the fbink pid still being alive also work (or would we be back to "race condition" territory?). |
Avoid hanging during extraction if fbink crashed.
Avoid hanging during extraction if fbink crashed.
Avoid hanging during extraction if fbink crashed.
Avoid hanging during extraction if fbink crashed.
Avoid hanging during extraction if fbink crashed.
benoit-pierre
force-pushed
the
pr/more_robust_ota_updates
branch
from
August 7, 2026 23:11
5c82688 to
609bbb1
Compare
Member
Author
|
It guess it depends on the crash. The tests in #15802 show that a simple text call works, but trying to draw a progress bar crashes. And yes, this would be in race territory anyway, how long do we wait before assuming the startup was successful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid hanging during extraction if fbink crashed.
Depend on koreader/koreader-base#2503 (for NiLuJe/FBInk#90).
This change is