Harden runtime validation and HTTP behavior#39
Draft
krotname wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
Several edge cases were handled permissively: unknown DaData values were collapsed into NOT_ACTIVE, resource endpoint overrides were ignored, request JSON was assembled with string formatting, health checks accepted a matching substring, and JDK HttpServer prefix routing exposed unintended paths. Server startup/stop also did not own the virtual-thread executor lifecycle.
During review, the newly reachable UNKNOWN state exposed a UI regression because it inherited the default green status style. The existing mutation suite also scored 79%, below the configured 80% gate, because request and boundary behavior was not asserted precisely enough.
Impact
Configuration failures now fail clearly, downstream requests are safely encoded and bounded by timeouts, unsupported paths/methods return deterministic errors, lifecycle resources are released, and future DaData statuses no longer appear inactive or visually successful.
Validation
git diff --checkpassedLocal Maven was kept offline. It used cached compatible overrides JUnit 6.1.0, CycloneDX 2.9.1, and PIT 1.25.4 because the exact current artifacts were not cached. CycloneDX SBOM generation is skipped by that offline mode. GitHub CI will validate the committed current versions, SBOM, Docker image, smoke test, and security workflows. Local Docker was unavailable (daemon query timed out).