ci: sync optimizer image version - #111
Open
lntutor wants to merge 1 commit into
Open
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
fetch-optimizer-versionstep assumesxmllintis available on the runner; consider adding an explicit installation step or a fallback parser to avoid silent CI breakage on environments without it. - The version extraction for
defaultOptimizerImageTagand correspondingsedreplacement is regex-based like the others; it may be worth tightening these patterns (e.g., anchoring or matching full lines) to reduce the chance of unintended matches if the constants file is refactored. - The commit message and summary always include an Optimizer version, even when
needs_optimizer_updateis false; consider making the messaging conditional to clearly reflect when only Autotune/UI changed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `fetch-optimizer-version` step assumes `xmllint` is available on the runner; consider adding an explicit installation step or a fallback parser to avoid silent CI breakage on environments without it.
- The version extraction for `defaultOptimizerImageTag` and corresponding `sed` replacement is regex-based like the others; it may be worth tightening these patterns (e.g., anchoring or matching full lines) to reduce the chance of unintended matches if the constants file is refactored.
- The commit message and summary always include an Optimizer version, even when `needs_optimizer_update` is false; consider making the messaging conditional to clearly reflect when only Autotune/UI changed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Hi @lntutor, thanks for opening your first pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the Kruize version-sync workflow to fetch the Optimizer version, verify its Quay tag, compare it with the tracked default, and update the default and sample image when an update is available.
Fixes #100
Checks
mainPOM version extraction (1.0.0-SNAPSHOT)fetch-optimizer-versiongit diff --checkmake test— blocked before tests by the repository bootstrap:setup-envtestis not produced at the expected path for its rename step.Summary by Sourcery
Extend the Kruize version sync workflow to track and update the Optimizer image version alongside Autotune and UI.
CI: