Skip to content

ci: sync optimizer image version - #111

Open
lntutor wants to merge 1 commit into
kruize:mainfrom
lntutor:ci/sync-optimizer-100
Open

ci: sync optimizer image version#111
lntutor wants to merge 1 commit into
kruize:mainfrom
lntutor:ci/sync-optimizer-100

Conversation

@lntutor

@lntutor lntutor commented Jul 26, 2026

Copy link
Copy Markdown

Summary

Extend the Kruize version-sync workflow to fetch the Optimizer version, verify its Quay tag, compare it with the tracked default, and update the default and sample image when an update is available.

Fixes #100

Checks

  • Workflow YAML parses with Ruby Psych
  • Optimizer main POM version extraction (1.0.0-SNAPSHOT)
  • Workflow structure assertion for fetch-optimizer-version
  • git diff --check
  • make test — blocked before tests by the repository bootstrap: setup-envtest is not produced at the expected path for its rename step.

Summary by Sourcery

Extend the Kruize version sync workflow to track and update the Optimizer image version alongside Autotune and UI.

CI:

  • Add a workflow step to fetch the Kruize Optimizer version from the main branch POM and expose it as an output.
  • Verify Optimizer image availability on Quay and factor it into the overall update decision logic.
  • Include Optimizer version comparisons in the update-check step and gate updates on image availability.
  • Update constants and sample YAML with the new Optimizer image tag when an update is needed.
  • Expand the auto-commit message and workflow summaries to report Optimizer version changes and status.

@sourcery-ai

sourcery-ai Bot commented Jul 26, 2026

Copy link
Copy Markdown

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new fetch-optimizer-version step assumes xmllint is available on the runner; consider adding an explicit installation step or a fallback parser to avoid silent CI breakage on environments without it.
  • The version extraction for defaultOptimizerImageTag and corresponding sed replacement is regex-based like the others; it may be worth tightening these patterns (e.g., anchoring or matching full lines) to reduce the chance of unintended matches if the constants file is refactored.
  • The commit message and summary always include an Optimizer version, even when needs_optimizer_update is false; consider making the messaging conditional to clearly reflect when only Autotune/UI changed.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `fetch-optimizer-version` step assumes `xmllint` is available on the runner; consider adding an explicit installation step or a fallback parser to avoid silent CI breakage on environments without it.
- The version extraction for `defaultOptimizerImageTag` and corresponding `sed` replacement is regex-based like the others; it may be worth tightening these patterns (e.g., anchoring or matching full lines) to reduce the chance of unintended matches if the constants file is refactored.
- The commit message and summary always include an Optimizer version, even when `needs_optimizer_update` is false; consider making the messaging conditional to clearly reflect when only Autotune/UI changed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shreyabiradar07

Copy link
Copy Markdown
Contributor

Hi @lntutor, thanks for opening your first pull request.

  1. Please ensure all your commits are signed with your GPG key
  2. Update the target base branch of this PR to mvp_demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update sync-kruize-versions workflow to include optimizer image

2 participants