docs: add CONTRIBUTING.md for kruize-operator - #116
Open
shreyabiradar07 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
Reviewer's GuideAdds a comprehensive CONTRIBUTING.md that defines the contribution workflow, tooling prerequisites, build/test commands, PR checks, commit message conventions, code style guidelines, and issue reporting process for the kruize-operator repository. Flow diagram for the new contribution workflow in CONTRIBUTING.mdflowchart TD
Contributor([Contributor])
ForkRepo["Fork kruize-operator repository"]
CloneRepo["Clone fork and set up locally"]
CreateBranch["Create topic branch from mvp_demo"]
MakeChanges["Implement changes following coding guidelines"]
InstallPrereq["Install prerequisites (Go, operator-sdk, Docker/Podman, kubectl)"]
BuildOperator["Run build commands (make generate manifests, docker-build)"]
RunTests["Run tests (make test, make test-e2e)"]
FixIssues["Fix build/test issues"]
PushBranch["Push topic branch to fork"]
OpenPR["Open pull request against kruize-operator"]
PRChecks["Automated PR checks (.github/workflows/pr-check.yaml)"]
ReviewMerge["Review and merge"]
Contributor --> ForkRepo --> CloneRepo --> CreateBranch --> InstallPrereq --> MakeChanges --> BuildOperator --> RunTests
RunTests -->|tests pass| PushBranch --> OpenPR --> PRChecks -->|checks pass| ReviewMerge
RunTests -->|tests fail| FixIssues --> MakeChanges
PRChecks -->|checks fail| FixIssues --> MakeChanges --> BuildOperator --> RunTests
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider validating and updating the version constraints in the Prerequisites section (Go, operator-sdk, kubectl, Kubernetes/OpenShift) so they match what is actually enforced by the project’s build tooling and CI, and call out if they are minimum vs tested versions.
- The Contribution Workflow currently instructs contributors to branch off
mvp_demo; if that is not the long-term default development branch, you may want to clarify when to usemvp_demoversusmainto avoid confusion for new contributors. - Double-check that all relative links (e.g.,
test/Operator_tests.md,.github/workflows/pr-check.yaml) resolve correctly from the repository root, and adjust paths or add brief context where needed if those files live in subdirectories.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider validating and updating the version constraints in the Prerequisites section (Go, operator-sdk, kubectl, Kubernetes/OpenShift) so they match what is actually enforced by the project’s build tooling and CI, and call out if they are minimum vs tested versions.
- The Contribution Workflow currently instructs contributors to branch off `mvp_demo`; if that is not the long-term default development branch, you may want to clarify when to use `mvp_demo` versus `main` to avoid confusion for new contributors.
- Double-check that all relative links (e.g., `test/Operator_tests.md`, `.github/workflows/pr-check.yaml`) resolve correctly from the repository root, and adjust paths or add brief context where needed if those files live in subdirectories.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Shreya Biradar <shbirada@ibm.com> Assisted-by: Bob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CONTRIBUTING.md file for kruize-operator
Summary by Sourcery
Documentation: