Add Bulk Profile, Cluster Config & Recommendation Settings classes - #33
Open
bharathappali wants to merge 6 commits into
Open
Add Bulk Profile, Cluster Config & Recommendation Settings classes#33bharathappali wants to merge 6 commits into
bharathappali wants to merge 6 commits into
Conversation
Signed-off-by: bharathappali <abharath@redhat.com>
Reviewer's GuideAdds client support and model classes for Kruize bulk profile APIs, including BulkProfile, ClusterConfig, and RecommendationSettings, wired via new constants and GET endpoints. Sequence diagram for bulk profile retrieval via KruizeClientsequenceDiagram
actor ClientApp
participant KruizeClient
participant KruizeService
alt all_profiles
ClientApp->>KruizeClient: getBulkProfiles()
KruizeClient->>KruizeService: GET /bulkProfiles
KruizeService-->>KruizeClient: BulkProfile[] JSON
KruizeClient-->>ClientApp: BulkProfile[]
else single_profile
ClientApp->>KruizeClient: getBulkProfile(profileName)
KruizeClient->>KruizeService: GET /bulkProfiles?profile_name=profileName
KruizeService-->>KruizeClient: BulkProfile JSON
KruizeClient-->>ClientApp: BulkProfile
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The bulk profile model classes use
Stringfor timestamp fields (createdAt,updatedAt) and other structured values likemeasurementDuration; consider using more specific types (e.g.,Instant,Duration) to make parsing/validation less error-prone. - Several fields that have constrained domains (
scheduling,experimentTypes,models,datasources) are represented as plain strings; introducing enums or dedicated value objects would help prevent invalid values and clarify expected options. - The new client methods for bulk profiles currently return raw
String; if possible, consider returning typed model objects (e.g.,BulkProfileorList<BulkProfile>) to avoid manual JSON handling and improve type safety in callers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The bulk profile model classes use `String` for timestamp fields (`createdAt`, `updatedAt`) and other structured values like `measurementDuration`; consider using more specific types (e.g., `Instant`, `Duration`) to make parsing/validation less error-prone.
- Several fields that have constrained domains (`scheduling`, `experimentTypes`, `models`, `datasources`) are represented as plain strings; introducing enums or dedicated value objects would help prevent invalid values and clarify expected options.
- The new client methods for bulk profiles currently return raw `String`; if possible, consider returning typed model objects (e.g., `BulkProfile` or `List<BulkProfile>`) to avoid manual JSON handling and improve type safety in callers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
bharathappali
force-pushed
the
feat-bulk-prof-3
branch
from
July 9, 2026 05:01
a8a2103 to
aa9210a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #32
#32 needs to be merged before this PR
This PR adds Bulk Profile, Cluster Config & Recommendation Settings classes
Summary by Sourcery
Introduce bulk profile support in the optimizer client and data model to represent bulk profiles, cluster configuration, and recommendation settings.
New Features:
Enhancements: