Fix: correct %g significant digit handling and update test#980
Open
peripherium wants to merge 1 commit intoksh93:devfrom
Open
Fix: correct %g significant digit handling and update test#980peripherium wants to merge 1 commit intoksh93:devfrom
peripherium wants to merge 1 commit intoksh93:devfrom
Conversation
_sfcvt() incorrectly limited n_digit based on the number of digits
before the decimal point, causing printf("%.Ng") to emit fewer than
N significant digits for large values.
Adjust n_digit to depend solely on the requested precision and only
truncate when the underlying buffer does not provide enough digits.
This restores correct %g semantics.
Update the corresponding test to use typeset -lE (SFFMT_LDOUBLE)
instead of -E. The previous test passed unintentionally
because the truncation masked precision differences. The tested
number of significant digits requires double precision to produce
reliable results.
Fixes ksh93#952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sfcvt() incorrectly limited n_digit based on the number of digits before the decimal point, causing printf("%.Ng") to emit fewer than N significant digits for large values.
Adjust n_digit to depend solely on the requested precision and only truncate when the underlying buffer does not provide enough digits. This restores correct %g semantics.
Update the corresponding test to use typeset -lE (SFFMT_LDOUBLE) instead of -E. The previous test passed unintentionally because the truncation masked precision differences. The tested number of significant digits requires double precision to produce reliable results.
Fixes #952