Skip to content

fix: types for module resolution bundler - #835

Merged
stijnvanhulle merged 4 commits into
kubb-labs:mainfrom
julian99m:fix/types-for-module-resolution-bundler
Sep 3, 2026
Merged

fix: types for module resolution bundler#835
stijnvanhulle merged 4 commits into
kubb-labs:mainfrom
julian99m:fix/types-for-module-resolution-bundler

Conversation

@julian99m

@julian99m julian99m commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🎯 Changes

Added explicit types param for each exports field in package.json files, so that they can be used by "modern" bundlers (which do not read the "legacy" top-level types field).
Disabled tsdown's automatic exports generation, as it does not support export-specific types and thus keeps overwriting the previously mentioned changes.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is for the docs (no release).

... as it overrides each `exports` element's type field and does not seem to be necessary
... as it overrides each `exports` element's type field and does not seem to be necessary
@codesandbox

codesandbox Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d696fde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@kubb/plugin-axios Patch
@kubb/plugin-cypress Patch
@kubb/plugin-faker Patch
@kubb/plugin-fetch Patch
@kubb/plugin-mcp Patch
@kubb/plugin-msw Patch
@kubb/plugin-react-query Patch
@kubb/plugin-redoc Patch
@kubb/plugin-swr Patch
@kubb/plugin-ts Patch
@kubb/plugin-vue-query Patch
@kubb/plugin-zod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 3, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~16 changed · 🔴 -0 removed · 0 flows · 32 files · commit d696fde


Architecture

Architecture diagram for kubb-labs/plugins at d696fde

16 components touched across 7 lanes.

Open full size


Data flow

No data-flow sequence changed in this PR.


Drill down
Internal Foundation — 4 components
🟡 CHANGED @⁠internals/utils

Internal utility helpers; exports explicit type definitions.

🟡 CHANGED @⁠internals/shared

Shared internal configurations and tools; exports explicit type definitions.

🟡 CHANGED @⁠internals/client

Client generation internals; exports explicit type definitions.

🟡 CHANGED @⁠internals/tanstack-query

TanStack Query shared logic; exports explicit type definitions.

Types & Validation — 2 components
🟡 CHANGED @⁠kubb/plugin-ts

TypeScript type generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-zod

Zod schema generator plugin; exports explicit type definitions.

HTTP Clients — 2 components
🟡 CHANGED @⁠kubb/plugin-fetch

Fetch client generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-axios

Axios client generator plugin; exports explicit type definitions.

Data Fetching Hooks — 3 components
🟡 CHANGED @⁠kubb/plugin-react-query

React Query hooks generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-vue-query

Vue Query hooks generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-swr

SWR hooks generator plugin; exports explicit type definitions.

Testing & Mocking — 3 components
🟡 CHANGED @⁠kubb/plugin-faker

Faker mock data generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-msw

Mock Service Worker generator plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-cypress

Cypress test generator plugin; exports explicit type definitions.

Integrations & Docs — 2 components
🟡 CHANGED @⁠kubb/plugin-mcp

Model Context Protocol plugin; exports explicit type definitions.

🟡 CHANGED @⁠kubb/plugin-redoc

Redoc documentation generator plugin; exports explicit type definitions.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it full size on a page of its own, where you can.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Something drawn wrong?

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 950014dc-85c0-4998-b400-d25e271652e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Sep 3, 2026
@stijnvanhulle
stijnvanhulle merged commit db58c6f into kubb-labs:main Sep 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants