infra(CI): remove test-e2e GitHub Actions workflow

[vitorfloriano]

Description

This PR removes the e2e test workflow. The e2e tests have been migrated to Prow as periodic jobs.

See: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-periodics.yaml

Follow-up to kubernetes/test-infra#37165
Follow-up to #210 (comment)

Type of Change

/kind cleanup

[netlify]

✅ Deploy Preview for node-readiness-controller ready!

Name	Link
🔨 Latest commit	955904d
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a5feeb544804b00089e3ed1
😎 Deploy Preview	https://deploy-preview-307--node-readiness-controller.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vitorfloriano]

/cc @ajaysundark
/cc @Priyankasaggu11929

Now that the e2e tests are green in Prow (see the testgrid), perhaps we could remove them from GHA workflows.

The only question I have is if we shouldn't have at least one presubmit job with the most recent k8s version to help spot changes that may break e2e. WDYT?

/hold

[vitorfloriano]

/cc @Priyankasaggu11929
/uncc @priyaaakansha

[Priyankasaggu11929]

The only question I have is if we shouldn't have at least one presubmit job with the most recent k8s version to help spot changes that may break e2e. WDYT?

yes, the idea is to move the existing gh workflow tests to prow.
so, we should add one presubmit.
this one can be used - https://github.com/kubernetes/test-infra/blob/9b391474f607e28a3dc789b32841a3cd776b4c04/config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-periodics.yaml#L1-L41

---

Also, we have a new make target test-e2e-kind which is doing more or less same as test-e2e - so, i think we can clean up test-e2e target now -

had left a note here earlier for this cleanup - #270 (comment)

[vitorfloriano]

so, we should add one presubmit.

Opened a PR: kubernetes/test-infra#37459

[vitorfloriano]

Testgrid looking good: https://testgrid.k8s.io/sig-node-node-readiness-controller#pull-node-readiness-controller-test-e2e

Shall we move on with this one?

/unhold

[Priyankasaggu11929]

Also, we have a new make target test-e2e-kind which is doing more or less same as test-e2e - so, i think we can clean up test-e2e target now -

had left a note here earlier for this cleanup - #270 (comment)

@vitorfloriano, could you please include this change as well. Thanks!

After that yes, ready to merge.

[vitorfloriano]

Hi @Priyankasaggu11929

I removed the redundant test-e2e target and the setup and cleanup as well since test-e2e-kind takes care of the entire lifecycle of the nrr-test kind cluster.

PTAL.