[occm] Fix serviceMonitor labelSelector and remove deprecated bearerTokenFile auth

[claudia-lola]

What this PR does / why we need it:
The labels on the Service did not match the ServiceMonitor selector. Prometheus was unable to discover the target. This change sets the labels so the ServiceMonitor selects the correct Service.
bearerTokenFile is deprecated and no longer works. ServiceMonitor was updated to use a supported authentication method.
authorization-always-allow-paths="/metrics" was added to ensure metrics can be scraped.
Which issue this PR fixes(if applicable):
fixes #3144

Special notes for reviewers:

Release note:

Fix serviceMonitor labelSelector and remove deprecated bearerTokenFile auth

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: claudia-lola / name: Claudia Watson (57d51da, 596b5dc, 8f36583, e6d8842)

[k8s-ci-robot]

Welcome @claudia-lola!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @claudia-lola. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kayrus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[claudia-lola]

Hi @kayrus @stephenfin and @zetaab what is the estimate for a review of this PR please?

[jihyun-huh]

Hi, @claudia-lola
I opened issue #3144 to describe the operational problem this PR addresses.
I think it provides additional context around to reviewers why this change is needed.

[jihyun-huh]

@gouthampacha Hi, i saw you are looking into this repo, can i friendly ask you for adding ok-to-test tag?

[gouthampacha]

/ok-to-test

[jihyun-huh]

Hi, @claudia-lola I added some small reviews.
apart from that, the approach looks reasonable to me.

[jihyun-huh]

could you clean this difference?

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kayrus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jihyun-huh]

Thanks @claudia-lola,
Ive reviewed the latest update and verified the rendered chart locally with serviceMonitor.enabled=true.

Hi, @kayrus I don’t see any remaining blockers from my side. Looks good to merge.

[jihyun-huh]

Hi @claudia-lola , one small follow-up after #3080 was merged, the OCCM chart version on master is now 2.36.1, which is the same version currently used in this branch.

cloud-provider-openstack/charts/openstack-cloud-controller-manager/Chart.yaml

Line 7 in d4b45ce

version: 2.36.1

Could you please rebase on the latest master and update the chart version to 2.36.2?

cc. @gouthampacha @kayrus

[jihyun-huh]

@gouthampacha, would you be able to take a reviewer pass and add /lgtm, if this looks good?

cc. @kayrus for approval after the reviewer pass. This fixes the out-of-the-box ServiceMonitor issue described in #3144.

[gouthampacha]

/lgtm

looks good, thanks @claudia-lola