feat(openstack-cloud-controller-manager): add splitMode

[cwrau]

What this PR does / why we need it:

This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.

That way the cluster is not dependent "on itself".

Special notes for reviewers:

The management mode only deploys the controller and the workload mode only
deploys the necessary RBAC roles and bindings.

Release note:

[openstack-cloud-controller-manager] Allow deploying the controller-manager split between management and workload clusters.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cwrau]

This has shown itself to be useful when theres trouble with the nodes resulting in dozens or hundreds of NotReady nodes which in turn break other stuff like cilium, as their pods get scheduled there and will never run.

And the ccm can't clean those nodes up, as it doesn't run yet.

With this one can run the ccm outside the cluster which makes sure that it always works™️

[cwrau]

Ok, I thought I had to bump the chart version as I had to for #3067, but that also didn't help and I don't know how I would fix that dependency issue

[cwrau]

Hello, is there something I can do to get this merged?

[cwrau]

@dulek / @Kayruz

Hello, not to be annoying, but is there something I can do to help getting this merged? 🙏

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kayrus]

Hi @cwrau. Thanks for the PR. Please remove the ZIP file from the PR and fix lint issues.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cwrau]

Hi @cwrau. Thanks for the PR. Please remove the ZIP file from the PR

Oh, I assuemed the zip was wanted, as there is no .gitignore.

and fix lint issues.

There aren't linting issues, the linter doesn't run because it fails building the dependencies, it seems CI must be adjusted? In our helm charts repo we set CT_CHARTS_REPOS to the repos so ct can download them itself:

      - name: Extract helm repos
        id: helm-repos
        run: |
          [[ "$RUNNER_DEBUG" == 1 ]] && set -x
          (
            echo -n "repos="
            yq -r '.dependencies[] | .repository' "charts/$CHART/Chart.yaml" | sort -u | grep https:// | awk '{printf (NR>1 ? "," : "") NR "=" $1}'
            echo
          ) | tee -a "$GITHUB_OUTPUT"
...
      - name: Lint chart
        env:
          CT_CHART_REPOS: ${{ steps.helm-repos.outputs.repos }}
          CT_CHARTS: charts/${{ matrix.chart }}
        run: |
          [[ "$RUNNER_DEBUG" == 1 ]] && set -x
          if ! [[ -f "charts/$CHART/values.yaml" ]]; then
            echo "No values.yaml found for $CHART, skipping 'ct lint'" >&2
            helm lint "charts/$CHART"
          else
            ct lint --check-version-increment=false
          fi

[kayrus]

@cwrau please bump the chart version

[cwrau]

@cwrau please bump the chart version

Done 👌

[kayrus]

/ok-to-test

[cwrau]

The tests seem to fail because of a quota error?

[kayrus]

/test pull-cloud-provider-openstack-test

@cwrau no, it seems there are some race conditions.