chore(config): remove unused Config fields with no readers#836
Conversation
These fields are not referenced anywhere in node-agent — nothing reads them, and removing them (plus their viper defaults) has no effect on behavior. This trims the Config struct and the documented config surface. Removed: backendStorageEnabled, hostMalwareSensorEnabled, hostNetworkSensorEnabled, testMode. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughFour fields ( ChangesConfig struct field removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Performance Benchmark ResultsNode-Agent Resource Usage
Dedup EffectivenessNo data available. |
What
Removes four
Configfields (and their viper defaults) that are not referenced anywhere in node-agent:backendStorageEnabledhostMalwareSensorEnabledhostNetworkSensorEnabledtestModeWhy
Nothing in the codebase reads these fields, so they have no effect on behavior — they only add noise to the
Configstruct and the documented config surface. Dropping them keeps the config lean.Safety
grepshows zero readers of the struct fields or their mapstructure keys outsidepkg/config.go build ./...andgo test ./pkg/config/...pass.🤖 Generated with Claude Code
Summary by CodeRabbit