fix(crew-state): stop passed runs from implying PR landing - #2778
Open
Mr-Neutr0n wants to merge 2 commits into
Open
fix(crew-state): stop passed runs from implying PR landing#2778Mr-Neutr0n wants to merge 2 commits into
Mr-Neutr0n wants to merge 2 commits into
Conversation
A pipeline passed outcome is a claim about the run's own nine steps, not about the forge. The PR is typically still open awaiting a human merge decision, and rendering 'PR merged/closed' invents landing that the helper never established (issue kunchenguid#2421). Say what is known: the run passed and the PR awaits review/merge. Landing remains teardown's own pr_is_merged determination. Adds a regression test proving the detail line never renders a merged/closed claim for an outcome=passed run; it fails against the old wording and passes with this change. Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
Gate review finding: 'PR awaiting review/merge' still asserts forge state that outcome=passed does not establish, just in the other direction (the PR may already be merged or absent). Render a neutral 'run passed: pipeline complete' and tighten the regression test to reject any PR-state claim in the detail line. Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. Passed runs retain their authoritative Reviews (1): Last reviewed commit: "fix(crew-state): make the passed-run det..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
passedpipeline outcome aspipeline completewithout claiming that its PR merged or closed.Risk Assessment
✅ Low: Captain, the change is narrowly scoped and truthfully maps a passed pipeline to pipeline completion without claiming unverified forge state; the regression test exercises observable helper output.
Testing
No prior baseline command was supplied. The focused crew-state behavior suite passed, and a base-versus-target CLI counterfactual proved the fix end to end: the base falsely claimed
PR merged/closed, while the target reportsrun passed: pipeline completewith or without a PR URL. CLI transcripts provide the reviewer-visible evidence; no UI screenshot applies to this shell-output change.Evidence: Target commit CLI transcript
Source: Target commit CLI transcript
Input: outcome=passed, PR field contains a URL state: done · source: run-step · run passed: pipeline complete Input: outcome=passed, PR field is empty state: done · source: run-step · run passed: pipeline completeEvidence: Base commit regression reproduction
Source: Base commit regression reproduction
Input: outcome=passed, PR field contains a URL state: done · source: run-step · run passed: PR merged/closed Input: outcome=passed, PR field is empty state: done · source: run-step · run passed: PR merged/closedPipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash tests/fm-crew-state.test.shExecuted the real targetbin/fm-crew-state.shwithoutcome: passedand both populated and empty PR fields usingpassed-run-cli-evidence.sh.Extracted basedc0172c48b36a6303501af25d0915ad6e7d04192:bin/fm-crew-state.shwithgit showand ran the same CLI harness to reproduce the falsePR merged/closedclaim.✅ **Document** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.