Make @ViewBuilder trailing parameter positioning opt-in via .viewBuilderTrailing#5
Merged
Merged
Conversation
…derTrailing Previously, @Slots always reordered generated init parameters by tier (values, closures, then @ViewBuilder), which doesn't always match the author's intent. Now declaration order is preserved by default. Use @Slots(.viewBuilderTrailing) to opt in to the old behavior when trailing closure syntax is desired. https://claude.ai/code/session_01FLoLtxvKf5acuAYipuYwka
Update unit and integration tests to match the new default behavior where parameters preserve declaration order instead of being sorted by tier. https://claude.ai/code/session_01FLoLtxvKf5acuAYipuYwka
The ToolbarRow preview passed title before leading, but with declaration order preserved, leading (idx 0) now comes before title (idx 1). https://claude.ai/code/session_01FLoLtxvKf5acuAYipuYwka
…rder The test now verifies declaration order is preserved, not that closures get reordered. https://claude.ai/code/session_01FLoLtxvKf5acuAYipuYwka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, @Slots always reordered generated init parameters by tier (values,
closures, then @ViewBuilder), which doesn't always match the author's intent.
Now declaration order is preserved by default. Use @Slots(.trailingViewBuilders)
to opt in to the old behavior when trailing closure syntax is desired.
https://claude.ai/code/session_01FLoLtxvKf5acuAYipuYwka