feat(http-client-python): export TypedDicts from namespace-root __init__.py#7
Closed
l0lawrence wants to merge 1 commit into
Closed
feat(http-client-python): export TypedDicts from namespace-root __init__.py#7l0lawrence wants to merge 1 commit into
l0lawrence wants to merge 1 commit into
Conversation
…t__.py In dpg and typeddict models modes, generated TypedDicts (and their Union/Literal aliases) live in types.py but were never re-exported from the namespace-root __init__.py. Import them from .types and add to __all__ so they can be imported directly from the package. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
All changed packages have been documented.
Show changes
|
Owner
Author
|
Retargeting to microsoft/typespec:main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
dpgandtypeddictmodels modes, generatedTypedDicts (and theirUnion/Literalaliases) are written totypes.py, but they were never re-exported from the namespace-root__init__.py— only clients and__version__were. As a result,from <package> import MyModeldid not work; the TypedDicts were only reachable via the implicittypessubmodule (from <package> import types; types.MyModel).Change
general_serializer.py— addedtypeddict_names_for_init(), which mirrors the exact gate and name-selection used to generatetypes.py(literal_enums+discriminated_base_models+typeddict_modelsviaTypesSerializer) so only names that actually exist intypes.pyare imported. Returns[]for the async (aio/) init sincetypes.pylives at the namespace root.serialize_init_filenow feeds these names to the template.init.py.jinja2— emitsfrom .types import (...)and adds the names to__all__when present.This covers both DPG mode (TypedDict copies of input models,
base="typeddict") and typeddict mode (all models as TypedDicts).Result
Tests
Added 4 unit tests in
test_typeddict.py:aio/) init does not import from.types.typesimportValidation
blackformatted,pylint10.00/10tests/unitfailures (XML/model_base serialization) are pre-existing and reproduce on a clean checkoutfeaturechronus changelog entry