Refactor duplicated site scripts into shared JS/gf-utils.js helpers - #3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Refactor duplicated site scripts into shared JS/gf-utils.js helpers#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation site repeated the same few patterns dozens of times (13 copy-pasted
partN()loaders inapp.js, 40 identical_keyCustomblocks incode/part-eight.js, 4 identical ajax callbacks incode/part-two.js, ...). This addsJS/gf-utils.js— a small layer on top ofGF-1.js, loaded byindex.htmlright after it — and rewrites those call sites in terms of it. Net −335 lines, no behaviour change.New helpers:
_bindClick(idsOrMap, fu),_bindKey(codeMap),_printKeyTo(id, labelMap),_responseTo(id),_alertUrl(url),_nextIndex(i, len),_printAll(idContentMap).app.js: the 13partN()functions, their 14_onClickbindings and the 14-branchif/elsechain behind INSERT collapse into one table + one loader:INSERT keeps the old semantics (
home→ part1, partN → partN+1, part13 → part1) viadocumentationPage.indexOf(now_page), and still does nothing when the current page isGet-Start/All-Function.One intentional behaviour fix: the PREVIOUS key in
code/part-eight.jsused to_writeLog("PREVIOUS")and log the wrong key code instead of printing todisplay_key— the table-driven version makes it behave like every other key.Verified in Chrome against a local static server: parts 4, 8, 9 and 11 render, nav clicks and INSERT navigation work, key labels print, and the color cycling in part 11 still rotates.
Link to Devin session: https://app.devin.ai/sessions/fc017cd138aa4772a02a07db257dbf5d
Requested by: @lamhotsimamora