Add Helm chart for Kubernetes deployment - #16
Merged
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charts/spectogram: a Helm chart deploying theservecontainer as aDeployment+Service, with optionalIngress,HPA, and an opt-ingenerateJob(runs the Go CLI against aConfigMap-provided audio file, writing to the samePVCtheDeploymentmounts)ClusterIP, chart-managedPVCon the cluster's defaultStorageClass, noIngress) work unmodified onkind; overridingimage.repository/image.tag,service.type,ingress.*, andpersistence.storageClassNamecovers cloud/on-premhelm testhookPodthat fetches/web/index.htmlthrough theServiceand asserts the Plotly viewer is served.github/workflows/helm.yml: lints and templates the chart on every relevant PR, and additionally builds the image, spins up a realkindcluster, runshelm install --wait, and runshelm testcharts/spectogram/README.md) and link it from the top-levelREADME.mdTest plan
helm lintandhelm template(default values, and all optional features enabled) pass locallykindcluster: built the image, installed the chart, confirmed thePVCbound, ran thegenerateJobagainst a synthesized WAV via aConfigMap, confirmed the output landed on the sharedPVCand was served through theService, andhelm testpassedgo build,go vet,gofmt,go test -race -coverstill passactionlintpasses on the new workflowkind-installjob (same flow, automated) passes