🤖 Astra: [AI quality improvement] Add graceful fallback to batch embedding requests - #79
🤖 Astra: [AI quality improvement] Add graceful fallback to batch embedding requests#79lanryweezy wants to merge 3 commits into
Conversation
…dding requests Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
💡 What: We previously mapped batch embedding requests in
server/ai.tsandserver/ai-enhanced.tsinside aPromise.allbut we missed fixing the downstream array. When a single request gets a 429 error and thecatchreturns[], it's not enough to return[]because it then gets passed downstream tocosineSimilaritywhich expects equal length arrays.🎯 Why: If a
Promise.allembedding batch fails,cosineSimilaritycomputes0and adds invalid/corrupted records to the UI.📊 Impact: We now use
continueif the embeddings array length is 0 so those users aren't shown, rather than being returned as a valid record with 0 similarity.🔬 Verification: Added
candidateEmbedding.length === 0check. Test suite passes.PR created automatically by Jules for task 1177602537499173445 started by @lanryweezy