Skip to content

🤖 Astra: [AI quality improvement] Add graceful fallback to batch embedding requests - #79

Open
lanryweezy wants to merge 3 commits into
mainfrom
astra-ai-quality-improvement-1177602537499173445
Open

🤖 Astra: [AI quality improvement] Add graceful fallback to batch embedding requests#79
lanryweezy wants to merge 3 commits into
mainfrom
astra-ai-quality-improvement-1177602537499173445

Conversation

@lanryweezy

Copy link
Copy Markdown
Owner

💡 What: We previously mapped batch embedding requests in server/ai.ts and server/ai-enhanced.ts inside a Promise.all but we missed fixing the downstream array. When a single request gets a 429 error and the catch returns [], it's not enough to return [] because it then gets passed downstream to cosineSimilarity which expects equal length arrays.
🎯 Why: If a Promise.all embedding batch fails, cosineSimilarity computes 0 and adds invalid/corrupted records to the UI.
📊 Impact: We now use continue if the embeddings array length is 0 so those users aren't shown, rather than being returned as a valid record with 0 similarity.
🔬 Verification: Added candidateEmbedding.length === 0 check. Test suite passes.


PR created automatically by Jules for task 1177602537499173445 started by @lanryweezy

…dding requests

Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nolly-crew Ready Ready Preview Aug 27, 2026 4:08am

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 647e4e06-166a-4cdc-bf88-28772a0c603f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
Co-authored-by: lanryweezy <101323524+lanryweezy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant