Adopt the family conventions - #1
Merged
Merged
Conversation
This package predates them. It was the oldest thing in the org -- last touched 2023 -- with correct vendor and Providers/ layout and almost nothing else. PUBLIC NAMES. The config key and view namespace were the bare slug. Laravel keeps both in flat global maps, so a second package claiming one replaces this silently and the failure surfaces elsewhere as a missing view. The publish tags were already vendor-scoped, which is what made the gap easy to miss by eye: two of the four names were right. DEPENDENCIES. PHP >=8.0 becomes the family floor ^8.4.1 || ^8.5. laravel/framework becomes the individual illuminate/* components actually used -- a package should not require the whole framework. And laravel/pint moves out of require, where it was forcing a dev tool into every consuming application. Adds the test suite and CI this had none of, a LICENSE, and a docs tree. The naming test reads the LIVE registries -- View::getFinder() ->getHints() and the config repository -- rather than grepping the provider, so it survives a refactor of the registration code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among the oldest things in the org — last touched 2023 — with the correct vendor and
Providers/layout and almost nothing else: no tests, no CI, no
LICENSE, nodocs/, PHP>=8.0, and adefault branch of
master.Public names
The config key and view namespace were the bare slug. Laravel keeps both in flat global maps,
so a second package claiming one replaces this silently, surfacing elsewhere as a missing view or the
wrong config value.
The publish tags were already vendor-scoped, which is what made the gap easy to miss by eye: two
of the four names were right.
git-commit-checkerlaranail.git-commit-checkergit-commit-checkerlaranail/git-commit-checkerlaranail::git-commit-checker-*Views take the slash form because Laravel interpolates the namespace into the override path, so an
override now lands in
resources/views/vendor/laranail/git-commit-checker.Dependencies
>=8.0→^8.4.1 || ^8.5, the family floor.laravel/framework→ the individualilluminate/*components actually used. A package shouldnot require the whole framework.
laravel/pintout ofrequire, where it forced a dev tool into every consuming application.Added
A test suite and CI (SHA-pinned per the org standard), a
LICENSE, adocs/tree, and abranch-alias.The naming test reads the live registries —
View::getFinder()->getHints()and the configrepository — not the provider source, so it survives a refactor of the registration code.
Also done outside this diff
masterwas renamed tomain, per the org branch convention.Breaking
Anyone reading
config('git-commit-checker.…')orview('git-commit-checker::…')must move to the scoped names.