Add missing return type diagnostics and quick fixes#653
Open
eramitgupta wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new return type feature for PHP methods/functions in the Laravel VS Code extension.
This change:
What was added
returnTypediagnostic providerreturnTypeLaravel.returnType.diagnosticsCovered return type cases
The feature now avoids warnings when a return type already exists, including examples like:
arrayintstringmixed?string?intstring|arrayCountable&TraversablestaticUserRedirectResponseQuick fix behavior
When no return type is declared, the extension now suggests adding one.
Examples of inferred suggestions:
return [];->: arrayreturn "text";->: stringreturn 1;->: intreturn true;->: boolreturn new User();->: Userreturn;or no return value ->: voidA fallback
: mixedquick fix is also provided.Tests
Verified with:
npm run check-typesnpm test -- --grep "Return Type Test Suite"Notes
This feature currently checks whether a return type is declared and offers suggestions when missing.
It does not yet validate whether the declared return type matches the actual returned value.