Skip cleanup for built-in modules#34
Merged
Merged
Conversation
Return early from verto_cleanup when BUILTIN_MODULE is defined. This prevents unloading module records and destroying global mutexes when the library is compiled statically, as dynamic module cleanup is unnecessary for built-in modules. Signed-off-by: Simo Sorce <simo@redhat.com>
Remove the centos:8 distribution target from the GitHub Actions CI workflow matrix. CentOS 8 has reached its End of Life (EOL) and is no longer maintained, making it obsolete for ongoing automated testing. Signed-off-by: Simo Sorce <simo@redhat.com>
Member
Author
culrpit snippet from #33 (comment) |
Collaborator
|
LGTM. The CentOS8 failure is due to it removed from CentOS mirroring already, so the second commit that makes us to not test on CentOS8 is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return early from verto_cleanup when BUILTIN_MODULE is defined. This prevents unloading module records and destroying global mutexes when the library is compiled statically, as dynamic module cleanup is unnecessary for built-in modules.
This is the proper fix for the valgrind issues posted on PR #33