ci: Bump actions/setup-node from 4 to 7 - #2
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 7. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v7) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
latentharbor
added a commit
that referenced
this pull request
Aug 1, 2026
Captured two ClientHellos off the wire from this machine's Chromium rather than working from recollection, and the capture corrected something that would otherwise have been built wrong. #1: 51914 27 10 35 16 13 5 43 23 51 65281 18 65037 17613 45 11 35466 #2: 23130 13 51 27 18 5 11 35 43 45 23 65037 10 65281 16 17613 6682 Identical non-GREASE extension SET, entirely different orders, a GREASE extension first and last both times with a different value each time. **Chromium shuffles its extension order on every connection.** So "match Chrome's extension order" is not a fixed list to copy — it is a shuffle, and `extensionOrder: 'shuffle'` is what reproduces it. A fixed Chrome order would have been wrong in a way no amount of care in choosing the list could have fixed. GREASE placement, also from the capture: one value first in the cipher list, one extension at each end (leading empty, trailing a single zero byte), one first in supported_groups, one first in supported_versions, and a key_share entry first carrying a one-byte key. ALPN and signature_algorithms carry none. Off by default, because curl does not GREASE. Turning it on by default would make this package look LESS like its stated reference, not more. Seeded rather than drawn from ambient randomness: repo-hygiene forbids Math.random in src/ so that every byte on the wire is reproducible in a test, and a fingerprint that cannot be reproduced cannot be asserted byte-for-byte. A number is the seed; `true` draws one from the injected randomBytes. Two ordering constraints are enforced regardless of what is asked for. pre_shared_key stays last of all, ahead of the trailing GREASE — RFC 8446 s4.2.11 defines the binder transcript as the hello truncated just before the binders, a range that only exists if nothing follows them. And the GREASE bookends are applied AFTER ordering; doing it the other way round put both at the end under a fixed order, since neither reserved type appears in any order list, and put the trailing one after the pre_shared_key. A server that negotiates a GREASE value is refused with a typed error naming RFC 8701. This needed its own check: the value WAS offered, so the existing "was it offered" test would have passed it through to a missing-parameters error whose message blames this package's own offer list. 1178 offline tests. The edge interop suite passes unchanged, which it must — with GREASE off the default hello is byte-identical to before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 4 to 7.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
8207627Migrate to ESM and upgrade dependencies (#1574)04be95cAdd cache-primary-key and cache-matched-key as outputs (#1577)7c2c68ddocs: Update caching recommendations to mitigate cache poisoning risks (#1567)6a61c03Merge pull request #1569 from jasongin/update-actions-cache-5.1.030eb73bResolve high-severity audit issues4e1a87aUpdate dist360237fStrict equality4f8aac5Bump@actions/cacheto 5.1.0, log cache write deniedf4a67bbOnly usemirrorTokeningetManifestif it's provided (#1548)0355742Remove dummy NODE_AUTH_TOKEN export (#1558)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)