MF3-H03: fix(nitronode): skip unsupported NodeBalanceUpdated tokens instead of fatal

[philanton]

Finding (MF3-H03)

ChannelHubReactor.HandleEvent() treated any handler error as fatal: it returned before StoreContractEvent(), so Listener.processEvents() unsubscribed and main() exited via logger.Fatal().

depositToNode() accepts any ERC20 and emits NodeBalanceUpdated. handleNodeBalanceUpdated() required the token to be configured in the node asset store, so depositing an unconfigured ERC20 was a permissionless, low-cost way to stop nitronode event processing. Since the failing event was never recorded, it replayed on restart — recovery needed manual intervention or a config/code change.

Fix

• New core.ErrTokenNotSupported sentinel, returned (wrapped) by the memory asset store's GetTokenAsset/GetTokenDecimals when a token is not configured.
• handleNodeBalanceUpdated() checks errors.Is(err, core.ErrTokenNotSupported), logs a warning, skips the balance update, and returns nil. HandleEvent() then records the event via StoreContractEvent(), so it is not replayed, the listener stays subscribed, and the process does not die.
• Genuine store errors still propagate — only the deterministic "not configured" case is skipped (typed error, not a catch-all).

Out of scope (per finding's optional suggestion): broader listener-level error classification so handler failures don't all collapse to logger.Fatal. Can follow up separately.

Tests

• New subtest unsupported token is skipped and recorded: asserts HandleEvent returns nil, StoreContractEvent is called, the balance handler is NOT called, and the processed callback reports success.
• go test ./pkg/blockchain/evm/... ./nitronode/store/memory/... and go vet pass.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 15e9d5fd-1226-4e17-91fb-49d3a63a42bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mf3-h03

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nksazonov]

Excellent work — the MF3-H03 fix is correct, minimal, and the new subtest locks in the right invariants (HandleEvent returns nil, processedSuccess=true, balance handler not called, StoreContractEvent is called). Verified locally: targeted test passes, go vet clean across the touched packages, CI fully green.

[ihsraham]

Requesting changes for one remaining H-03 closure gap. The typed skip is the right shape for configured chains with unknown tokens, but an enabled chain with no token map still returns a generic error and can hit the old fatal listener path. I left the exact branch inline.

[ihsraham]

Approved for H-03. The no-token-map branch now returns the same ErrTokenNotSupported sentinel as the unknown-token branch, so the world_chain/chain 480 case skips cleanly and still reaches StoreContractEvent for dedup. The added asset/decimals and reactor tests cover the closure path; no remaining blockers from me.

[nksazonov]

All three review comments addressed in 887b14e — verified locally: mirror subtest for the GetTokenDecimals skip branch, skipIfUnsupportedToken helper de-dups both guards, helper doc comment spells out the no-replay (dedup, not replay) semantics. Bonus follow-up from @ihsraham on the enabled-chain-no-tokens path (e.g. world_chain 480) also wrapped in core.ErrTokenNotSupported with memory_store regressions. go test ./pkg/blockchain/evm/... ./nitronode/store/memory/... green. LGTM.