fix(sparql-anything): remove stale chunks with five or more digits - #834
Open
ddeboer wants to merge 1 commit into
Open
fix(sparql-anything): remove stale chunks with five or more digits#834ddeboer wants to merge 1 commit into
ddeboer wants to merge 1 commit into
Conversation
- chunk() pads the index to four digits, so the 10,000th chunk onwards has five; removeChunksOf() matched exactly four and left those behind on a re-run - Cover it with a 10,001-row input chunked at one row and re-chunked at a larger size - Document that the paths chunk() returns are the list to convert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunk()pads the chunk index to four digits, so the 10,000th chunk onwards gets a five-digit name.removeChunksOf()matched\d{4}exactly and left those behind, so a re-run at a larger chunk size kept the earlier run’s tail in the directory – and in geonames-rdf, in the output.chunk()returns as the list of chunks to convert, rather than listing the directory.Fix #823