Skip to content

[#14968] perf: cache the innermost scope state in ScopedEnvExtension.StateStack #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
downstream-lean4 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[#14968] perf: cache the innermost scope state in ScopedEnvExtension.StateStack #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394f238
downstream: follow upstream PR
downstream-lean4[bot] Aug 29, 2026
c87c3ba
mathlib4: drop now-unused `Inhabited` binder on `warnAttr`
Kha Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lean-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
leanprover/lean4:nightly-2026-08-27
leanprover/lean4-pr-releases:pr-release-14968-d1863d1
2 changes: 1 addition & 1 deletion mathlib4/Mathlib/Tactic/Translate/Core.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ def warnAttrCore (stx : Syntax) (f : Environment → Name → Bool)
else ""

/-- Warn the user when the declaration has a simple scoped attribute. -/
def warnAttr {α β : Type} [Inhabited β] (stx : Syntax) (attr : SimpleScopedEnvExtension α β)
def warnAttr {α β : Type} (stx : Syntax) (attr : SimpleScopedEnvExtension α β)
(f : β → Name → Bool) (thisAttr attrName src tgt : Name) : CoreM Unit :=
warnAttrCore stx (f <| attr.getState ·) thisAttr attrName src tgt

Expand Down